Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start adding tests #77

Open
gavanderhoorn opened this issue Feb 21, 2020 · 2 comments
Open

Start adding tests #77

gavanderhoorn opened this issue Feb 21, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@gavanderhoorn
Copy link
Member

gavanderhoorn commented Feb 21, 2020 •
edited by jontje
Loading

As #76 highlighted, we need to start adding tests to important parts of the library to avoid regressions.

Initially I would suggest we focus on serialisation and deserialisation interfacing code, to document our expectations about the RWS msgs and make sure code layered on-top doesn't break when those messages change.
@gavanderhoorn gavanderhoorn added the enhancement New feature or request label Feb 21, 2020
@gavanderhoorn gavanderhoorn mentioned this issue Feb 21, 2020
Merged
@jontje
Copy link
Contributor

jontje commented Feb 21, 2020

@gavanderhoorn, I edited your comment from "protobuf msgs" to "RWS msgs", since protobuf it not used in RWS communication 😉

@gavanderhoorn
Copy link
Member Author

Thanks.

Too many things at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gavanderhoorn @jontje