Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Introduction of dead code in PR 81 #84

Open
jrgnicho opened this issue Jan 13, 2020 · 0 comments
Open

Revert Introduction of dead code in PR 81 #84

jrgnicho opened this issue Jan 13, 2020 · 0 comments
Assignees

Comments

@jrgnicho
Copy link
Member

#81 attempted to address a segfault in the applyEqualDistance function however rather than fixing the bug, a whole new function with the same name was created while the original one was renamed to applyEqualDistance_original and kept around even though it's not being referenced anywhere else in the code. Unless the new function can guarantee the right output (equally distanced points that lie on the actual curve) , my preference would be to fix the original function and remove the new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants