-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
footprint_clearing_enabled for more (or all) layers #4277
Comments
The voxel layer derives from the obstacle layer and they share the same Since its a param, I have no issue with it being applied to the static layer as well! 😄 Please submit a PR and that should be easy to merge |
I'm wrong then, was purely code review (after I found 'clearing_layers' not used I assumed there is more 😬)
What do you think about a param to apply it to the whole costmap instead of by layer? I haven't checked if that's easily feasible but I assume so |
I think we should leave it on a layer by layer basis for granularity of controls. I suppose we could offer both though like we have for some settings. That would be fine! |
Spinoff from #4271 (comment)
Feature request
Feature description
footprint_clearing_enabled
is only a parameter of the obstacle layer. it's also in the voxel layer but doesn't seem to be used. I think it would make sense if this parameter was also implemented for the static layer. Going further, we can also argue for it to be at top-level costmap such that it applies to all layers/Implementation considerations
The text was updated successfully, but these errors were encountered: