Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magic number in getConversionCodes() #532

Open
galou opened this issue May 6, 2024 · 0 comments
Open

Magic number in getConversionCodes() #532

galou opened this issue May 6, 2024 · 0 comments

Comments

@galou
Copy link

galou commented May 6, 2024

There is a magic 5 in getConversionCodes(). Shouldn't it actually be 10, the last index of the Encoding enum?

Anyway, a comment should be added explaining the number there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@galou