Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check URDF to distinguish fixed joints from floating joints. Floating… #32

Merged
merged 1 commit into from
Sep 24, 2015

Conversation

toliver
Copy link
Contributor

@toliver toliver commented Sep 1, 2015

… joints are ignored by the publisher (no segment is added for them).

Fixes #19

Maybe this warning should be modified to make it clear that it happens at the KDL level only, but the robot_state_publisher is still able to distinguish.

@ugocupcic
Copy link

Hi,

Anything we can do to help speeding up that merge?

Cheers,

@isucan
Copy link
Contributor

isucan commented Sep 24, 2015

This looks good, but can you make the request against the jade branch?

isucan added a commit that referenced this pull request Sep 24, 2015
Check URDF to distinguish fixed joints from floating joints. Floating…
@isucan isucan merged commit c7fd32e into ros:indigo-devel Sep 24, 2015
@isucan
Copy link
Contributor

isucan commented Sep 24, 2015

On further consideration and discussion with @wjwwood, this has a low chance of causing problems, so merged in indigo. Thank you for your fix!

@ugocupcic
Copy link

OK great thanks for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants