Upgrade mac and Windows CI hosts before Dashing Patch 3

[nuclearsandwich]

In order to produce usable binaries for Dashing Patch Release 3 this needs to be completed ahead of time, ideally with time to stabilize after any potential issues.

I've got the checklist I've used to do this at https://gist.github.com/nuclearsandwich/63ef5a2868ae8a7a6167283789e1a71e

Upgrade logs https://gist.github.com/nuclearsandwich/d4aa90b7c6532ff412fb13cb597bb9ab

[nuclearsandwich]

There is at least one known update that makes our MacOS binaries unusable on systems with up-to-date Homebrew installations: ros2/rosidl#403

[nuclearsandwich]

As wjwwood did last week, starting with a canary host each

icecube 🎐
mini1 🍎

[nuclearsandwich]

Fresh builds

mini1 🍎
icecube 🎐

[j-rivero]

Ouch, mini1 is green. @nuclearsandwich do you want to launch it again to be sure it is ok?

[nuclearsandwich]

Ouch, mini1 is green. @nuclearsandwich do you want to launch it again to be sure it is ok?

No actually I'm fine with that. I'm having trouble remembering if I rebooted mini1 before the first build.

[nuclearsandwich]

Dashing MacOS CI

There will probably be a few flake8 issues here which are due to a new error code. Other failures will need to be investigated.

[j-rivero]

There will probably be a few flake8 issues here which are due to a new error code. Other failures will need to be investigated.

11 failures all related to flake8 and uncrustify.

[j-rivero]

portable [update log]

[j-rivero]

mini2.local [update log]

[j-rivero]

mini3.local [update log]

There is one failing test in sros2 that does not seem related to uncrustify or flake8: https://ci.ros2.org/job/test_ci_osx/170/testReport/junit/sros2.test/test_policy_to_permissions/test_policy_to_permissions/

[nuclearsandwich]

@j-rivero has windshield been updated? If so I think this issue can be closed.

[j-rivero]

@j-rivero has windshield been updated? If so I think this issue can be closed.

It wasn't. It is now: [update log]

[nuclearsandwich]

Thanks!

[dirk-thomas]

It would be good to know from which version cppcheck was updated. Related to ros2/rmw_fastrtps#318.

[nuclearsandwich]

It would be good to know from which version cppcheck was updated.

No cppcheck updates were available when I first started this process on 2019-08-28. As you can see from the upgrade log in the top post. @j-rivero's upgrade logs don't appear to include the from version for chocolatey (which is understandable as you have to do that work manually).

Looking at icecube cppcheck 1.88 is installed and cppcheck 1.89 was released 2019-09-01. So my educated guess is that the previous version was cppcheck 1.88.

Also @cottsay we should probably square up icecube with the other windows hosts.

[cottsay]

Also @cottsay we should probably square up icecube with the other windows hosts.

After alignment with portable: [update log]