Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rcl_ros_clock_init stores pointer to allocator rather than storing a copy #267

Closed
wjwwood opened this issue Jul 10, 2018 · 0 comments · Fixed by #274
Closed

rcl_ros_clock_init stores pointer to allocator rather than storing a copy #267

wjwwood opened this issue Jul 10, 2018 · 0 comments · Fixed by #274
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@wjwwood
Copy link
Member

wjwwood commented Jul 10, 2018

See: #264 (comment)

This line should be changed so that the given allocator is copied, either by allocating memory to store the allocator struct as a pointer in the rcl_clock_t or by changing the pointer to an allocator in the rcl_clock_t to an instance and then assigning the incoming allocator structure to the one in the rcl_clock_t:

clock->allocator = allocator;

@wjwwood wjwwood added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Jul 10, 2018
@dhood dhood self-assigned this Jul 31, 2018
@dhood dhood added the in progress Actively being worked on (Kanban column) label Jul 31, 2018
@dhood dhood closed this as completed in #274 Aug 1, 2018
@dhood dhood removed the in progress Actively being worked on (Kanban column) label Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants