move serialized_message from rmw #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(sorry if this is not ready for review) I think we mentioned renaming this to be more agnostic as this really is just a binary blob. serialized_message implies a serialization format that from my understanding will be added to the rmw structure and not the rcutils one. Does this make sense? Maybe the name change is planned for later when the structures will diverge and not be just forwarded? |
|
agreed. I was planning on renaming, but as you mentioned, in a second run. |
Karsten1987
added
in review
|
@Karsten1987 do you still need this branch ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to ros2/rmw#144