-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show size contribution of each topic with ros2 bag info #1601
Comments
cross-linking related question: https://answers.ros.org/question/318667/using-rosbag-to-get-size-of-each-topic/ |
I could work on a PR to address this issue. |
Nice @nicolaloi, I recently stumbled upon the topic throttle node which can throttle by bytes published and looking at its implementation, @MichaelOrlov do you think it's feasible? Do you have some implementation directions? |
@tonynajjar @nicolaloi, The scope of the changes, is not clear to me. |
Since you're discussing implementations details, I'll assume that this information is gatherable in the first place. |
My opinion as ROS 2 user: For both options, I think you only need to crawl over messages of variable size (i.e. containing unbounded arrays, like About the possible "get the size of variable-size messages" overhead for both options, the However, the bag should also be opened and processed with the first option, so I think it will have an extra overhead. With the second option, I think the only overhead should be more or less the As a user, I would probably prefer to have these size statistics in the metadata (second option). However, if its overhead is problematic, natively getting the statistics from |
Another piece of code to take inspiration from for msg size: https://github.com/ros2/ros2cli/blob/rolling/ros2topic/ros2topic/verb/bw.py |
@tonynajjar The first option is relatively easy to implement. I would suggest going with the first option for begging as a first stage. |
I randomly stumbled on the PR for this issue today, it's awesome that it is now merged! Thanks a lot @nicolaloi. I guess we can close the issue now? |
|
Description
I would like to know the contribution of each topic to the size of the the bag (e.g. to throttle, compress, downsample, etc...)
On humble this is the current output of
ros2 bag info
:Count
is already useful but not enough. I have no idea how the size would be calculated, is it difficult?The text was updated successfully, but these errors were encountered: