-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
missing break in switch-case in config.cpp? #152
Comments
I've encountered that too and I think this actually is a bug inherited from the mainline. GCC7 simply added My understanding is that there should be a Another issue is the project(rviz_common CXX) (solution found here) The two issues above are in fact unrelated to each other - I'm not sure whether it would be better to open a PR for both of them at once or separately? |
After fixing those issues I've hit another wall:
After setting
That effectively makes I've traced it down to find_package(yaml-cpp QUIET)
if(NOT yaml-cpp_FOUND)
(...)
else()
ament_package()
endif() To ensure proper linking of I'll create a PR soon. |
Looking forward to your PR :) btw: I noticed that |
The break is needed ? From https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7/ |
@Theosakamg yes, the break is indeed needed there. It's an upstream bug. @racko I have a slightly more complete solution for the |
Since the originally reported issue has been resolved in #158 I'm going to close this. |
Since in the CMakeLists.txt the compiler is set to pedandic and Werror, build fails on rviz_common/config.cpp:145 as there is no break in the case section when using gcc7 (gc 7.2.1 used here):
The text was updated successfully, but these errors were encountered: