Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined symbol in rosbag2_storage due to wrong version on yaml-cpp for MacOS Catalina. #19

Closed
olivier-stasse opened this issue Dec 11, 2020 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@olivier-stasse
Copy link

I run into issue ros2/rosbag2#298 and had to modify the CMakeLists.txt file to install yaml-cpp version 0.6.3

This was necessary to compile ros2 on a Mac Catalina 10.15.7

Making the modification proposed by @tanzby fixed the matter.

But will it not be possible to fix the matter for macOS and all by updating the version in this repository ?

@clalancette
Copy link
Contributor

But will it not be possible to fix the matter for macOS and all by updating the version in this repository ?

That is a good idea, yes. Would you be interested in making the change, testing it out locally, and proposing a PR to do that?

@clalancette clalancette added enhancement New feature or request help wanted Extra attention is needed labels Dec 14, 2020
@olivier-stasse
Copy link
Author

But will it not be possible to fix the matter for macOS and all by updating the version in this repository ?

That is a good idea, yes. Would you be interested in making the change, testing it out locally, and proposing a PR to do that?

Dear @clalancette,
Thanks for the feedback. Please find the following pull request #20

@clalancette
Copy link
Contributor

This should have been fixed by #25 , so closing this out. Feel free to reopen if you are still having problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants