Use system installed yaml-cpp 0.6 if available #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mjbogusz Hi, I saw the original version you made a comment there about the ament limitation. Do you know is it still something true? And do you mind to share what's the original problem you are hitting? |
ivanpauno
reviewed
Feb 28, 2020
|
After short googling I've found the PR that this originated from - it was 2 years ago and happened in ros2-rviz: ros2/rviz#160 (I guess before yaml-cpp was split to separate vendor package) As I recall and based on the aforementioned PR the issue originated from having the required version of |
|
Thanks for the insights @mjbogusz. |
|
I may state the obvious, but make sure to check whether building packages depending on |
Yes, I did that. I first build depending packages without installing yaml_cpp with I will give it a shot in bionic now, with yaml_cpp 0.5 installed, to see if it still builds 0.6. |
I also checked that it was using the system library in that case, and not building it again. |
Ok, it does the right thing too.
|
|
@seanyen Something went wrong on Windows, I don't have time to investigate right now. |
|
@ivanpauno hmm, on the Windows build agent, it found @brawner It is a long shot, but just curious, do you know if the Windows agent has |
|
I'm not sure about the bare-metal machines, but the container builds will become the default today and I don't think it's installed there. How is it installed on windows? Can it be added to the dockerfile? https://github.com/ros2/ci/blob/master/windows_docker_resources/Dockerfile.msvc2019 |
@brawner, actually this is my question too. :) I don't know how does the bare-metal one get prepared and don't know what's the environment there. However, sounds like now we are switching to container build so the environment will be cleaner. Just curious, is @ivanpauno able to kick off a container build against this change or we just wait? I would like to see if this problem manifest or not on the new environment. |
|
ci_windows is now officially built in a container, so rebuilding straight away is sufficient! |
The whole point is that it should find the system package, and work correctly when it does find it. |
@ivanpauno I am not sure what's the reference environment acceptable for this validation. However, I can provide some information on the In my settings, I have ros-eloquent-desktop built out on this sandbox channel https://anaconda.org/ros-playground: (and one of my goal is in favor of And for this validation, I can CLICK ME
And after doing CLICK ME
|
That's ok, but does |
|
@seanyen friendly ping |
|
@ivanpauno Sorry for the late on this. I did P.S., I am using https://github.com/ros2-gbp/rviz-release/tree/release/eloquent/rviz_common/7.0.4-1 and https://github.com/ros2-gbp/rosbag2-release/tree/release/eloquent/rosbag2_storage/0.2.4-1 as the targets. |
|
@ivanpauno friendly ping. |
|
@seanyen can you rebase? I will run CI after that. Thanks! |
seanyen
force-pushed
the
seanyen/portable
branch
from
348cdcc
to
0430b8a
Compare
Signed-off-by: seanyen <[email protected]>
Signed-off-by: seanyen <[email protected]>
Signed-off-by: seanyen <[email protected]>
seanyen
force-pushed
the
seanyen/portable
branch
from
0430b8a
to
0725e94
Compare
|
@ivanpauno rebased! |
|
CI:
|
ivanpauno
changed the title
|
Thanks for the contribution @seanyen !! |
|
This PR seems to have introduced a regression on macOS: see #14. |
ivanpauno
added a commit
that referenced
this pull request
Aug 24, 2020
This reverts commit b11d00f.
ivanpauno
added a commit
that referenced
this pull request
Aug 24, 2020
This reverts commit b11d00f. Signed-off-by: Ivan Santiago Paunovic <[email protected]>
ivanpauno
added a commit
that referenced
this pull request
Aug 25, 2020
This reverts commit b11d00f. Signed-off-by: Ivan Santiago Paunovic <[email protected]>
ivanpauno
added a commit
that referenced
this pull request
Aug 25, 2020
ivanpauno
added a commit
that referenced
this pull request
Aug 25, 2020
…15)" This reverts commit 251be27. Signed-off-by: Ivan Santiago Paunovic <[email protected]>
ivanpauno
added a commit
that referenced
this pull request
Sep 17, 2020
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the environments (vcpkg, conda-forge, etc..) which already have the
yaml-cpp, we can fallback to use the global one.