New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some details about merging before review and merging without edits #25

Open

steeleb opened this issue Sep 6, 2023 · 0 comments

Assignees

Collaborator

steeleb commented Sep 6, 2023

Merging before review:

author must make note in comments
be clear about whether tagging someone in a review is about an FYI or about an actual review that is required
it is the author's responsibility to follow up and make sure that all comments/suggestions/reviewers are satisfied later

Merging without edits/merging when 'changes requested'

sometimes, you just gotta keep chugging!
Make sure you (PR author) creates issues from review so that we don't inadvertently miss important info and feedback
Make sure you make a note in comments of the PR to communicate what has been done and what is left to do (and call out the issues created)

steeleb self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment