-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom strokes #59
Comments
What library are you using, which defines a stroke other than the BasicStroke? I would at least like to have a possibility to test this. |
Thanks for the quick response. It is not due to a library, it is my own code that has that issue. I derived strokes from the interface java.awt.Stroke because I need the stroke to be serializable and BasicStroke isn't (https://bugs.openjdk.org/browse/JDK-4305099). I can provide a test. |
Hmm, why are you not just deriving from BasicStroke and let that subclass implement Serializable? If you could just provide a very simple test, this would be helpful. |
Regarding a test case, I modified the test PdfBoxGraphics2dTest.testLineWithRotation() as follows:
Regarding implementing Serializable, yes it is possible but the class is immutable making it clunky. But yes, that is definitely an option. |
It seems that currently only java.awt.BasicStroke is supported.
Something like this could perhaps be added to the code:
The text was updated successfully, but these errors were encountered: