-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weird mode-line colors with nano-light #51
Comments
I think the theme is missing the mode-line-active that is a new face (I think). Can you check what's the face for mode-line-active (if it exists on your version) ? |
Using `(mode-line :inherit nano-subtle
:background nil
:foreground nil
:box (:color ,nano-light-faded :style nil))
`(mode-line-inactive
:inherit nano-subtle-i
:foreground nil
:background nil
:box nil) An now the active mode-line looks like this And the inactive one like this It should be abstracted into the nano-theme structure, but I, personally, think it looks better. WDYT? |
I looks nice! ActuallyI've tested the box in active mode before removing it because I found it a bit ditractng. A for the inactive mode, it's a bit too washed out. |
Yes. You certainly have a better judgement about this than I do, and my initial idea could be improved, of course. If you have a better config, I can help you to test it. |
I'm actually using the box with nano-vertico mode (to show this is an input area). I get inspired by nyxt. |
Can you open an issue on nano-vertico? |
Yes sure, no problem. |
maikol-solis’s config of
|
Hi!
Today I tried nano-light since a long ago and I have these weird colors in the mode-line
The colors for mode-line
And for mode-line-inactive
In the code everything looks right, but I don't know if I missed something
nano-theme/nano-theme-support.el
Lines 692 to 696 in 9d64dc1
Thanks.
The text was updated successfully, but these errors were encountered: