Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'display_next' doesn't work when a whole conversation is (marked as) deleted #9357

Open
the0ne opened this issue Feb 16, 2024 · 3 comments
Open

Comments

@the0ne
Copy link

the0ne commented Feb 16, 2024

'display_next' doesn't work when a whole conversation is (marked as) deleted.

@alecpl
Copy link
Member

alecpl commented Feb 25, 2024

Confirmed.

@alecpl alecpl added this to the later milestone Feb 25, 2024
@alecpl
Copy link
Member

alecpl commented Mar 16, 2024

The behavior is controlled by this code:

    this.check_display_next = function () {
        return this.env.display_next && (this.preview_id || !this.env.contentframe);
    };

This means that it will attempt to display the next message in two cases:

  • when a message is currently being displayed
  • when there's no content preview frame

So, it does not look like a bug.

The message won't be displayed also in case if you select a single message with Ctrl key and then delete it. So, we'll have to consider whether we want to open the next message no matter if any message is currently previewed. Which means we remove these extra conditions (the right side of &&).

For example Thunderbird does display next in any case, but it also always have some content in the preview frame.

@alecpl alecpl added enhancement and removed bug labels Mar 16, 2024
@the0ne
Copy link
Author

the0ne commented Mar 16, 2024

I agree that in the code it might not be a bug.

It still 'feels' like a bug from user perspective as it's really confusing that - depending on the conditions - displaying the next message sometimes works and sometimes not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants