Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty groups in addressbook silently not exported #9590

Open
2 tasks done
respiranto opened this issue Aug 17, 2024 · 3 comments
Open
2 tasks done

Empty groups in addressbook silently not exported #9590

respiranto opened this issue Aug 17, 2024 · 3 comments

Comments

@respiranto
Copy link
Contributor

Prerequisites

  • I have searched for duplicate or closed issues
  • I can recreate the issue with all plugins disabled

Describe the issue

When exporting an addressbook via the Roundcube web UI ("Export all"), any group without members is silently ignored.

What I would expect is either that empty groups are exported, or a warning message indicating that the respective groups without members could not be exported and why.

In particular, I would expect that the result of "Export all" (if no error is indicated) can be used with "Import" to recreate the original addressbook.

Given that Roundcube exports to the vCard 3.0 format (c.f. RFC 2426), and represents groups as values of CATEGORIES for each group member, it seems impossible to actually export a group without members.

Hence, I suggest a warning message specifying that certain to be named groups could not be exported because not having any members if that is the case.


Originally reported at the Debian BTS as Bug 1078777, where I was asked to report the bug here instead.

What browser(s) are you seeing the problem on?

Firefox

What version of PHP are you using?

v8.2

What version of Roundcube are you using?

master / 58721e3

JavaScript errors

No response

PHP errors

No response

@alecpl
Copy link
Member

alecpl commented Aug 17, 2024

vCard 4.0 solves the problem, but of course it's not a simple solution. A warning makes sense.

@alecpl alecpl added this to the later milestone Aug 17, 2024
@respiranto
Copy link
Contributor Author

respiranto commented Aug 17, 2024

Is vCard 4.0 support planned?

Relatedly, might I suggest using an external vCard library (e.g., sabre/vobject) to help address this and the other vCard-related issues?

@pabzm
Copy link
Member

pabzm commented Sep 16, 2024

Is vCard 4.0 support planned?

Not really. But I think we wouldn't oppose it if someone would implement it.

So (unless you want to tackle the job) I'd agree that a simple warning would be the best option. Would you like to implement that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants