Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elastic: special-buttons in dark-theme use @color-dark-background #9612

Open
2 tasks done
dschmidt opened this issue Aug 26, 2024 · 1 comment
Open
2 tasks done

elastic: special-buttons in dark-theme use @color-dark-background #9612

dschmidt opened this issue Aug 26, 2024 · 1 comment

Comments

@dschmidt
Copy link

Prerequisites

  • I have searched for duplicate or closed issues
  • I can recreate the issue with all plugins disabled

Describe the issue

I'm trying to change some colors in the elastic theme and I stumbled upon the dark theme explicitly setting the background for special-buttons to @color-taskmenu-background, which is inconsistent with the light mode where @color-taskmenu-background is used. See

background: @color-dark-background;

Why is that the case?
Light mode:
Screenshot_20240826_222544
Dark mode:

Screenshot_20240826_222625

Dark mode without the override or with explicitly setting special-buttons background to @color-taskmenu-background:
Screenshot_20240826_222717

I know with design there's no right or wrong - but I would expect that dark and light mode behave similarly.

What browser(s) are you seeing the problem on?

Firefox

What version of PHP are you using?

No response

What version of Roundcube are you using?

main

JavaScript errors

No response

PHP errors

No response

@pabzm
Copy link
Member

pabzm commented Sep 15, 2024

I think you're right. But:

@alecpl You made that skin, as far as I know. What do you think about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@dschmidt @pabzm and others