Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release a new version #215

Closed
4 tasks done
jannic opened this issue Nov 28, 2021 · 8 comments
Closed
4 tasks done

Release a new version #215

jannic opened this issue Nov 28, 2021 · 8 comments

Comments

@jannic
Copy link
Member

jannic commented Nov 28, 2021

There has not been a new release of rp2040-hal for several months. During that time, the crate improved significantly.
With a new release (0.3.0?), it would be much easier for newcomers to find those improvements.

As rp2040-hal depends on pio, which was not yet released to crates.io, there are a few steps to be taken:

  • publish pio to crates.io
  • update rp-hal/rp2040-hal to depend on the released version of pio
  • publish updated version of rp2040-hal
  • Update changelog before tagging the release
@9names
Copy link
Member

9names commented Dec 1, 2021

One more task so I don't forget:

  • Update changelog before tagging the release

@thejpster
Copy link
Member

thejpster commented Dec 18, 2021

embassy-rs is blocking us doing a release, because rp-hal git depends on embassy-traits.

$ cargo publish --dry-run
    Updating crates.io index
error: all dependencies must have a version specified when publishing.
dependency `embassy-traits` does not specify a version
Note: The published dependency will use the version from crates.io,
the `git` specification will be removed from the dependency declaration.

@thejpster
Copy link
Member

Asked about it in embassy-rs/embassy#549

@jannic
Copy link
Member Author

jannic commented Dec 18, 2021

As long as embassy-traits is not released to crates.io, it wouldn't be a huge loss to disable embassy-traits support in the published rp-hal as well.
(It's not necessary to remove the code. Commenting out the dependency and the feature in Cargo.toml seems to be sufficient.)

diff --git a/rp2040-hal/Cargo.toml b/rp2040-hal/Cargo.toml
index fdb766d..2abbf99 100644
--- a/rp2040-hal/Cargo.toml
+++ b/rp2040-hal/Cargo.toml
@@ -30,11 +30,11 @@ chrono = { version = "0.4", default-features = false, optional = true }
 
 # namespaced features will let use use "dep:embassy-traits" in the features rather than using this
 # trick of renaming the crate.
-[dependencies.embassy_traits]
-git = "https://github.com/embassy-rs/embassy"
-rev = "6d6e6f55b8a9ecd38b5a6d3bb11f74b2654afdeb"
-package = "embassy-traits"
-optional = true
+#[dependencies.embassy_traits]
+#git = "https://github.com/embassy-rs/embassy"
+#rev = "6d6e6f55b8a9ecd38b5a6d3bb11f74b2654afdeb"
+#package = "embassy-traits"
+#optional = true
 
 [dev-dependencies]
 cortex-m-rt = "0.7"
@@ -45,5 +45,5 @@ pio-proc = "0.1.0"
 
 [features]
 rt = ["rp2040-pac/rt"]
-embassy-traits = ["embassy_traits", "futures"]
+#embassy-traits = ["embassy_traits", "futures"]
 alloc = []

@thejpster
Copy link
Member

Doesn't it complain that embassy-traits isn't a feature any more?

@thejpster
Copy link
Member

Apparently not...

@thejpster
Copy link
Member

#242

@thejpster
Copy link
Member

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants