Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A typo in TrackBase.h #105

Closed
zhuqingzhang opened this issue Oct 1, 2020 · 2 comments
Closed

A typo in TrackBase.h #105

zhuqingzhang opened this issue Oct 1, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@zhuqingzhang
Copy link

In the function of set_calibration of Class TrackBase, there is a typo I guess. In the 107th line,

if(mtx_feeds.empty() || camera_k_OPENCV.empty() || camera_k_OPENCV.empty() || this->camera_fisheye.empty())

there are two "camera_k_OPENCV.empty()", and I assume one of these should be "camera_d_OPENCV.empty()", although it should not effect the performance of code.

@goldbattle goldbattle added the bug Something isn't working label Oct 1, 2020
@goldbattle
Copy link
Member

Thanks for the correction!

@goldbattle
Copy link
Member

Addressed in #117.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants