New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up on strict check for config file in environs/dotenv #44

Open

rptaylor opened this issue Apr 3, 2024 · 0 comments

Owner

rptaylor commented Apr 3, 2024

Currently the chart invokes KAPEL without a config file, instead using environment variables: https://github.com/rptaylor/kapel/blob/master/chart/templates/cronjob.yaml#L73

Nevertheless it is possible, and for CLI testing could be useful, to use a config file:
https://github.com/rptaylor/kapel/blob/master/python/KAPEL.py#L266

Follow up on sloria/environs#294 to fail explicitly if a config file is requested but not found.

However I'm not sure if this handles the undesirable situation that a stray config file could get used accidentally: https://github.com/rptaylor/kapel/blob/master/python/KAPELConfig.py#L6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment