From 250dbdc578d44f792168825953eac58281fcc790 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ren=C3=A9=20F=C3=B6hring?= Date: Thu, 14 Dec 2023 17:35:25 +0100 Subject: [PATCH] Rename tests to match other tests' naming --- .../check/refactor/filter_count_test.exs | 22 +++++++++---------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/test/credo/check/refactor/filter_count_test.exs b/test/credo/check/refactor/filter_count_test.exs index 7a09b12db..4df5db98f 100644 --- a/test/credo/check/refactor/filter_count_test.exs +++ b/test/credo/check/refactor/filter_count_test.exs @@ -7,7 +7,7 @@ defmodule Credo.Check.Refactor.FilterCountTest do # cases NOT raising issues # - test "does not trigger when using Enum.count/2" do + test "it should NOT report when using Enum.count/2" do """ defmodule Credo.Sample.Module do def some_function(p1, p2, p3, p4, p5) do @@ -20,7 +20,7 @@ defmodule Credo.Check.Refactor.FilterCountTest do |> refute_issues() end - test "does not trigger when piping list into Enum.filter/2 and piping result of that into Enum.count/2" do + test "it should NOT report when piping list into Enum.filter/2 and piping result of that into Enum.count/2" do """ defmodule Credo.Sample.Module do def some_function(p1, p2, p3, p4, p5) do @@ -35,7 +35,7 @@ defmodule Credo.Check.Refactor.FilterCountTest do |> refute_issues() end - test "does not trigger when filter-count pipeline is part of a larger pipeline using Enum.count/2" do + test "it should NOT report when part of a larger pipeline using Enum.count/2" do """ defmodule Credo.Sample.Module do def some_function(p1, p2, p3, p4, p5) do @@ -52,7 +52,7 @@ defmodule Credo.Check.Refactor.FilterCountTest do |> refute_issues() end - test "does not trigger when piping list into Enum.filter/2 and passing result as parameter to Enum.count/2" do + test "it should NOT report when piping list into Enum.filter/2 and passing result as parameter to Enum.count/2" do """ defmodule Credo.Sample.Module do def some_function(p1, p2, p3, p4, p5) do @@ -65,7 +65,7 @@ defmodule Credo.Check.Refactor.FilterCountTest do |> refute_issues() end - test "does not trigger when applying Enum.filter/2 to two arguments and passing result to Enum.count/2" do + test "it should NOT report when applying Enum.filter/2 to two arguments and passing result to Enum.count/2" do """ defmodule Credo.Sample.Module do def some_function(p1, p2, p3, p4, p5, p6) do @@ -78,7 +78,7 @@ defmodule Credo.Check.Refactor.FilterCountTest do |> refute_issues() end - test "does not trigger when applying Enum.filter/2 to two arguments and piping into Enum.count/2" do + test "it should NOT report when applying Enum.filter/2 to two arguments and piping into Enum.count/2" do """ defmodule Credo.Sample.Module do def some_function(p1, p2, p3, p4, p5) do @@ -96,7 +96,7 @@ defmodule Credo.Check.Refactor.FilterCountTest do # cases raising issues # - test "triggers when piping list into Enum.filter/2 and piping result of that into Enum.count/1" do + test "it should report a violation when piping list into Enum.filter/2 and piping result of that into Enum.count/1" do """ defmodule Credo.Sample.Module do def some_function(p1, p2, p3, p4, p5) do @@ -111,7 +111,7 @@ defmodule Credo.Check.Refactor.FilterCountTest do |> assert_issue() end - test "triggers when filter-count pipeline is part of a larger pipeline" do + test "it should report a violation when filter-count pipeline is part of a larger pipeline" do """ defmodule Credo.Sample.Module do def some_function(p1, p2, p3, p4, p5) do @@ -128,7 +128,7 @@ defmodule Credo.Check.Refactor.FilterCountTest do |> assert_issue() end - test "triggers when piping list into Enum.filter/2 and passing result as parameter to Enum.count/1" do + test "it should report a violation when piping list into Enum.filter/2 and passing result as parameter to Enum.count/1" do """ defmodule Credo.Sample.Module do def some_function(p1, p2, p3, p4, p5) do @@ -141,7 +141,7 @@ defmodule Credo.Check.Refactor.FilterCountTest do |> assert_issue() end - test "triggers when applying Enum.filter/2 to two arguments and passing result to Enum.count/1" do + test "it should report a violation when applying Enum.filter/2 to two arguments and passing result to Enum.count/1" do """ defmodule Credo.Sample.Module do def some_function(p1, p2, p3, p4, p5, p6) do @@ -154,7 +154,7 @@ defmodule Credo.Check.Refactor.FilterCountTest do |> assert_issue() end - test "triggers when applying Enum.filter/2 to two arguments and piping into Enum.count/1" do + test "it should report a violation when applying Enum.filter/2 to two arguments and piping into Enum.count/1" do """ defmodule Credo.Sample.Module do def some_function(p1, p2, p3, p4, p5) do