From 659c3205d66006674f74821fb643170e11eb48c4 Mon Sep 17 00:00:00 2001 From: Yun Feng Date: Wed, 12 Jun 2024 02:34:58 -0700 Subject: [PATCH 1/2] fix: extension doesn't work after vite bump --- .../src/components/SidebarWithHeader.tsx | 2 +- packages/web-extension/src/manifest.json | 6 +++--- .../src/{assets => public}/icon128.png | Bin .../web-extension/src/{assets => public}/icon16.png | Bin .../web-extension/src/{assets => public}/icon48.png | Bin packages/web-extension/vite.config.ts | 1 - 6 files changed, 4 insertions(+), 5 deletions(-) rename packages/web-extension/src/{assets => public}/icon128.png (100%) rename packages/web-extension/src/{assets => public}/icon16.png (100%) rename packages/web-extension/src/{assets => public}/icon48.png (100%) diff --git a/packages/web-extension/src/components/SidebarWithHeader.tsx b/packages/web-extension/src/components/SidebarWithHeader.tsx index b2235d7f66..bcc07147ff 100644 --- a/packages/web-extension/src/components/SidebarWithHeader.tsx +++ b/packages/web-extension/src/components/SidebarWithHeader.tsx @@ -117,7 +117,7 @@ const SidebarContent = ({ RRWeb Logo diff --git a/packages/web-extension/src/manifest.json b/packages/web-extension/src/manifest.json index 314a23aeee..482335d4c6 100644 --- a/packages/web-extension/src/manifest.json +++ b/packages/web-extension/src/manifest.json @@ -10,9 +10,9 @@ } ], "icons": { - "16": "assets/icon16.png", - "48": "assets/icon48.png", - "128": "assets/icon128.png" + "16": "icon16.png", + "48": "icon48.png", + "128": "icon128.png" }, "permissions": ["activeTab", "tabs", "storage", "unlimitedStorage"] }, diff --git a/packages/web-extension/src/assets/icon128.png b/packages/web-extension/src/public/icon128.png similarity index 100% rename from packages/web-extension/src/assets/icon128.png rename to packages/web-extension/src/public/icon128.png diff --git a/packages/web-extension/src/assets/icon16.png b/packages/web-extension/src/public/icon16.png similarity index 100% rename from packages/web-extension/src/assets/icon16.png rename to packages/web-extension/src/public/icon16.png diff --git a/packages/web-extension/src/assets/icon48.png b/packages/web-extension/src/public/icon48.png similarity index 100% rename from packages/web-extension/src/assets/icon48.png rename to packages/web-extension/src/public/icon48.png diff --git a/packages/web-extension/vite.config.ts b/packages/web-extension/vite.config.ts index 76d2c631a3..0fd0602706 100644 --- a/packages/web-extension/vite.config.ts +++ b/packages/web-extension/vite.config.ts @@ -84,7 +84,6 @@ export default defineConfig({ ); return manifest; }, - assets: 'assets', browser: process.env.TARGET_BROWSER, webExtConfig: { startUrl: ['github.com/rrweb-io/rrweb'], From 9d0d32cc403ca262c0b2b2cb75c604ffa4e51bfa Mon Sep 17 00:00:00 2001 From: Yun Feng Date: Wed, 12 Jun 2024 02:37:08 -0700 Subject: [PATCH 2/2] add changeset --- .changeset/lovely-files-sparkle.md | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 .changeset/lovely-files-sparkle.md diff --git a/.changeset/lovely-files-sparkle.md b/.changeset/lovely-files-sparkle.md new file mode 100644 index 0000000000..a845151cc8 --- /dev/null +++ b/.changeset/lovely-files-sparkle.md @@ -0,0 +1,2 @@ +--- +---