Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Non-Isomorphous Inputs #35

Closed
kmdalton opened this issue Oct 21, 2021 · 4 comments
Closed

Support Non-Isomorphous Inputs #35

kmdalton opened this issue Oct 21, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@kmdalton
Copy link
Member

It may be impossible to supply multiple mtz files without --separate-files in the current experimental branch. I should check on this and write a test.

@kmdalton kmdalton added the bug Something isn't working label Oct 21, 2021
@kmdalton kmdalton self-assigned this Oct 21, 2021
@kmdalton
Copy link
Member Author

It turns out this issue was caused by me providing two mtzs which were not isomorphous. I no longer consider this a bug. However, It is a good idea to come up with a better way to handle this by default. Options:

  • Refuse to merge non-isomorphous cells and provide a helpful error message
  • Use the first cell in the list to determine the ASU for merging
  • Use the average cell to determine the ASU for merging

@kmdalton kmdalton added enhancement New feature or request and removed bug Something isn't working labels Oct 27, 2021
@kmdalton kmdalton changed the title Multiple File Merging Broken in Experimental Non-isomorphism in Inputs Not Supported Nov 3, 2021
@kmdalton kmdalton changed the title Non-isomorphism in Inputs Not Supported Support Non-Isomorphous Inputs Nov 3, 2021
@JBGreisman
Copy link
Member

Just to comment on this -- the default behavior in rs for rs.concat(), DataSet.append(), DataSet.join(), and DataSet.merge() is to use the first cell in the list (or for the DataSet ones, to keep the cell of the calling DataSet). Each of the methods also have a check_isomorphous=True argument, that can be set to False to avoid this check.

Those methods and the check_isomorphous flag may provide a simple way to implement this sort of behavior.

@kmdalton
Copy link
Member Author

Related: #136

@kmdalton kmdalton added the wontfix This will not be worked on label Sep 11, 2024
@kmdalton
Copy link
Member Author

kmdalton commented Sep 11, 2024

Having mulled this isue over for quite some time, I'm afraid I have deemed it out of scope. It violates careless's contract with users to try to be clever about this. The mechanism by which users communicate cell info to careless is through their input mtz files, and we have provided a good tool to do that in reciprocalspaceship.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants