Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account for multiplicity in spot prediction/res-dep BW #54

Open
DHekstra opened this issue Jan 17, 2024 · 2 comments
Open

account for multiplicity in spot prediction/res-dep BW #54

DHekstra opened this issue Jan 17, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@DHekstra
Copy link
Contributor

since we have miller indices and spacegroup by the time we predict spots, we know the multiplicities of each spot. perhaps there is merit in adjusting the threshold accordingly. (granting that will require some thought to determine what "accordingly" means)

@DHekstra DHekstra added the enhancement New feature or request label Jan 17, 2024
@kmdalton
Copy link
Member

This should be straightforward to implement. I'm not sure if it'll make much difference, but it's an interesting idea.

@DHekstra
Copy link
Contributor Author

would it make sense to replace the KDE with logistic regression? with a set of strong reflections and a set of not strong reflections as the training data and wavelength, rlp, multiplicity, and possibly the image number as predictive variables?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants