diff --git a/rskj-core/src/test/java/co/rsk/peg/constants/BridgeConstantsTest.java b/rskj-core/src/test/java/co/rsk/peg/constants/BridgeConstantsTest.java index 6b1c2930fab..7535ea77f61 100644 --- a/rskj-core/src/test/java/co/rsk/peg/constants/BridgeConstantsTest.java +++ b/rskj-core/src/test/java/co/rsk/peg/constants/BridgeConstantsTest.java @@ -6,10 +6,10 @@ import static org.mockito.Mockito.when; import co.rsk.bitcoinj.core.Coin; -import co.rsk.peg.lockingcap.constants.LockingCapConstants; -import co.rsk.peg.lockingcap.constants.LockingCapMainNetConstants; -import co.rsk.peg.lockingcap.constants.LockingCapRegTestConstants; -import co.rsk.peg.lockingcap.constants.LockingCapTestNetConstants; +import co.rsk.peg.federation.constants.*; +import co.rsk.peg.feeperkb.constants.*; +import co.rsk.peg.lockingcap.constants.*; +import co.rsk.peg.whitelist.constants.*; import java.util.stream.Stream; import org.ethereum.config.blockchain.upgrades.ActivationConfig; import org.ethereum.config.blockchain.upgrades.ConsensusRule; @@ -31,10 +31,11 @@ private static Stream minimumPeginTxValueArgProvider() { @ParameterizedTest() @MethodSource("minimumPeginTxValueArgProvider") - void test_getMinimumPeginTxValue(BridgeConstants bridgeConstants, boolean isRSKIP219Active){ + void getMinimumPeginTxValue(BridgeConstants bridgeConstants, boolean isRSKIP219Active){ // Arrange ActivationConfig.ForBlock activations = mock(ActivationConfig.ForBlock.class); when(activations.isActive(ConsensusRule.RSKIP219)).thenReturn(isRSKIP219Active); + // Act Coin minimumPeginTxValue = bridgeConstants.getMinimumPeginTxValue(activations); @@ -56,7 +57,7 @@ private static Stream getBtcHeightWhenPegoutTxIndexActivatesArgProvid @ParameterizedTest() @MethodSource("getBtcHeightWhenPegoutTxIndexActivatesArgProvider") - void test_getBtcHeightWhenPegoutTxIndexActivates(BridgeConstants bridgeConstants, int expectedValue){ + void getBtcHeightWhenPegoutTxIndexActivates(BridgeConstants bridgeConstants, int expectedValue){ // Act int btcHeightWhenPegoutTxIndexActivates = bridgeConstants.getBtcHeightWhenPegoutTxIndexActivates(); @@ -82,6 +83,62 @@ void getPegoutTxIndexGracePeriodInBtcBlocks(BridgeConstants bridgeConstants, int assertEquals(expectedValue, pegoutTxIndexGracePeriodInBtcBlocks); } + @ParameterizedTest() + @MethodSource("getFeePerKbConstantsProvider") + void getFeePerKbConstants(BridgeConstants bridgeConstants, FeePerKbConstants expectedValue) { + // Act + FeePerKbConstants actualFeePerKbConstants = bridgeConstants.getFeePerKbConstants(); + + // Assert + assertInstanceOf(expectedValue.getClass(), actualFeePerKbConstants); + } + + private static Stream getFeePerKbConstantsProvider() { + return Stream.of( + Arguments.of(BridgeMainNetConstants.getInstance(), FeePerKbMainNetConstants.getInstance()), + Arguments.of(BridgeTestNetConstants.getInstance(), FeePerKbTestNetConstants.getInstance()), + Arguments.of(new BridgeRegTestConstants(), FeePerKbRegTestConstants.getInstance()) + ); + } + + @ParameterizedTest() + @MethodSource("getWhitelistConstantsProvider") + void getWhitelistConstants(BridgeConstants bridgeConstants, WhitelistConstants expectedValue) { + // Act + WhitelistConstants actualWhitelistConstants = bridgeConstants.getWhitelistConstants(); + + // Assert + assertInstanceOf(expectedValue.getClass(), actualWhitelistConstants); + } + + private static Stream getWhitelistConstantsProvider() { + return Stream.of( + Arguments.of(BridgeMainNetConstants.getInstance(), WhitelistMainNetConstants.getInstance()), + Arguments.of(BridgeTestNetConstants.getInstance(), WhitelistTestNetConstants.getInstance()), + Arguments.of(new BridgeRegTestConstants(), WhitelistRegTestConstants.getInstance()) + ); + } + + @ParameterizedTest() + @MethodSource("getFederationConstantsProvider") + void getFederationConstants(BridgeConstants bridgeConstants, FederationConstants expectedValue) { + // Act + FederationConstants actualFederationConstants = bridgeConstants.getFederationConstants(); + + // Assert + assertInstanceOf(expectedValue.getClass(), actualFederationConstants); + } + + private static Stream getFederationConstantsProvider() { + BridgeConstants bridgeRegTestConstants = new BridgeRegTestConstants(); + FederationConstants federationRegTestConstants = bridgeRegTestConstants.getFederationConstants(); + return Stream.of( + Arguments.of(BridgeMainNetConstants.getInstance(), FederationMainNetConstants.getInstance()), + Arguments.of(BridgeTestNetConstants.getInstance(), FederationTestNetConstants.getInstance()), + Arguments.of(bridgeRegTestConstants, new FederationRegTestConstants(federationRegTestConstants.getGenesisFederationPublicKeys())) + ); + } + @ParameterizedTest() @MethodSource("getLockingCapConstantsProvider") void getLockingCapConstants(BridgeConstants bridgeConstants, LockingCapConstants expectedValue){ @@ -89,7 +146,6 @@ void getLockingCapConstants(BridgeConstants bridgeConstants, LockingCapConstants LockingCapConstants actualLockingCapConstants = bridgeConstants.getLockingCapConstants(); // Assert - assertEquals(expectedValue, actualLockingCapConstants); assertInstanceOf(expectedValue.getClass(), actualLockingCapConstants); }