Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for netstandard2.0 #29

Open
isaacabraham opened this issue Aug 6, 2019 · 11 comments
Open

Support for netstandard2.0 #29

isaacabraham opened this issue Aug 6, 2019 · 11 comments

Comments

@isaacabraham
Copy link
Collaborator

Would it be possible to release a new version of this package that targets netstandard2.0 rather than 1.6? This has some benefits, one of which is that with the recent release of FSharp.Core 4.7, much simpler dependency graphs in Paket.

@rspeele
Copy link
Owner

rspeele commented Aug 7, 2019

My concern with this is that, given that TaskBuilder.fs is riddled with inline code, there's a good chance a new build targeting netstandard20 will not be binary-compatible with the old builds.

If so, releasing it would do more harm than good as it could lead to dependency conflicts that cannot be solved with binding redirects. For this reason I'm very hesitant to make any releases other than fixing correctness bugs, which fortunately have not been a problem. I would push for progress on the feature's eventual inclusion in F# Core instead, which should make life better for everybody.

@isaacabraham
Copy link
Collaborator Author

Hi. I can't comment on the binary compatibility risk so won't go there :-) But perhaps a major release number would alleviate those concerns? Also, if you keep the netstandard1.6 TFM, wouldn't that mean that people using 1.6 could continue to use it without a problem?

The eventual inclusion into F# Core would indeed resolve this in general but would necessitate a complete release of for all existing projects that use this. Releasing a new version here would mean that that was not necessary, and would benefit people using this library immediately.

@slang25
Copy link

slang25 commented Sep 3, 2019

I can't see binary compatibility being an issue here, like Isaac says it's an additional TFM. The benefits of a ns2.0 release would be worth adding IMO

@isaacabraham
Copy link
Collaborator Author

Now that NET Core 3 is out and FSharp.Core is completely on netstandard2.0, I'd love it if you would re-consider doing this now :-)

@forki
Copy link

forki commented Oct 18, 2019

Please release a new version. netstandard1.6 was a big mistake and the whole ecosystem is moving away from it

@isaacabraham
Copy link
Collaborator Author

@rspeele I understand that you might be busy with other things - I know you do this in your spare time. Would you consider bringing in someone to support you on this project in order to accept a PR on this?

Thanks!

@rspeele
Copy link
Owner

rspeele commented Dec 5, 2019

Hi,

Sorry I'm way behind on this one. I merged Isaac's PR and put it out at 2.2.0-alpha. If that seems to work well when mixed with existing libraries that reference 2.1.0, I'll re-release the same thing as 2.2.1 (not alpha).

@isaacabraham
Copy link
Collaborator Author

Happy to close this issue if everyone else is? :-)

@isaacabraham
Copy link
Collaborator Author

@rspeele any chance of pushing this as a non-alpha release? :-)

@slang25
Copy link

slang25 commented Feb 9, 2020

The alpha package looks good, would love for a release @rspeele

@slang25
Copy link

slang25 commented May 22, 2020

@rspeele Would you be happy to release a 2.2.1 of this package, it's looking good from tests here 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants