Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow progress bar to live inside of any element #14

Closed
wants to merge 4 commits into from

Conversation

jonjaques
Copy link
Contributor

This is useful in my case, where I have an admin panel-looking app, and I want to scope the loading animation to a specific pane.

I'm going to be honest, was lazy and did this PR on GitHub so I didn't run the tests.

However, I have a demo running here: http://jsbin.com/odOf/3

Fully willing to rebase this and resubmit, just let me know what you think. Thanks for this BTW.

@styfle
Copy link

styfle commented Aug 23, 2013

I second this request. This would be a great substitute to the typical "indeterminant spinner" every time something is clicked.

Now the next step would be multiple NProgress instances for different elements that are loading 👍

@lipis
Copy link
Contributor

lipis commented Aug 25, 2013

multiple nprogress instances I think it's too much for this component.. but putting in on a specific div is pretty good idea..!

@lipis
Copy link
Contributor

lipis commented Aug 28, 2013

on a second thought and after playing with it a bit more.. I think this kind of progress bar should be only one on the page ;) so maybe it's an overhead to make the whole thing configurable and stuff... let's keep it simple..
Plus is so simple that is not that hard to actually implement it the way you want..

@cryptiklemur
Copy link

This would be awesome to have

@silvermanners
Copy link

I was a bit let down that I can't position it in any div wrapper I want. This would be THE feature to have.

@frankie-loves-jesus
Copy link

👍

@rstacruz
Copy link
Owner

Done, thanks Jon!

See #86.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants