-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript typings not found #404
Comments
I really hope this will be fixed on the TypeScript side... It would look really weird to have such hacks in the pnpm codebase |
Maybe we can fall back to npm for some "blacklist" of popular packages... |
What about a flag --copy-typings or --no-link-typings ? Does not affect pnpm users and if Typescript fixes it then no need to set flag :) |
I understand, I am talking about the implementation. Seems like it will be the same that npm does, so we can just run |
Maybe hard links would solve this issue. |
This is going to be fixed in TypeScript 2.1.0. If you use typescript@next, it will work already |
I am closing this because the latest TypeScript is 2.1.0 now and it has all the symlink issues solved. So this will work with the latest TypeScript |
pnpm v0.39.0
node v6.5.0
OS Windows 7
Code to reproduce the issue:
Create a
test.ts
file with the following content:Then run:
Expected behavior:
Actual behavior:
I suggest we could copy the @types packages into node_modules instead of linking them. Seems to solve the issue as commented here: #394 (comment)
The text was updated successfully, but these errors were encountered: