You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Given that there isn't a global standard for yml file structures, this should not be a dependency for reading a config file.
I'd suggest replacing line 58 with default_config <- config_yaml[[config]] to have it check for the presence of the specified config, in the case that R_CONFIG_ACTIVE is specified as a value other than default or that a user specifies a config in the function call.
While this would work, I think re-writing that block to more specifically check for config as defined in the function call "default" or otherwise, as this step pretty intently looks strictly for "default".
Also, the documentation specifies R_CONFIG_NAME as the environment variable. It looks like this feature was not fully implemented in @jjallaire's branch.
Happy to (attempt) to make this change.
The text was updated successfully, but these errors were encountered:
I fully support this idea. It's great that this package supports having multiple configs (local, stage, prod, etc), but for many usecases all I want is just a single config. I just want to use a config file rather than hardcode parameters in the source code, but I don't have different configurations. It adds a bit of friction and unnecessary complexity to have to indent everything inside default:. It's also confusing when others who aren't familiar with this package look at the yml file and wonder what's the purpose of that first line.
Given that there isn't a global standard for yml file structures, this should not be a dependency for reading a config file.
I'd suggest replacing line 58 with
default_config <- config_yaml[[config]]
to have it check for the presence of the specified config, in the case thatR_CONFIG_ACTIVE
is specified as a value other than default or that a user specifies a config in the function call.While this would work, I think re-writing that block to more specifically check for
config
as defined in the function call "default" or otherwise, as this step pretty intently looks strictly for "default".Also, the documentation specifies
R_CONFIG_NAME
as the environment variable. It looks like this feature was not fully implemented in @jjallaire's branch.Happy to (attempt) to make this change.
The text was updated successfully, but these errors were encountered: