-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
be verbose if we're going to prompt #1615
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the documentation for any of the prompt
arguments or the renv.verbose
option discuss their interactions?
Hmm... we don't actually document the use of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree that it would be good to document this somewhere, but it's not clear where.
R/scope.R
Outdated
renv_scope_verbose_if <- function(value) { | ||
if (value) { | ||
renv_scope_options( | ||
renv.verbose = value, | ||
scope = parent.frame() | ||
) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renv_scope_verbose_if <- function(value) { | |
if (value) { | |
renv_scope_options( | |
renv.verbose = value, | |
scope = parent.frame() | |
) | |
} | |
} | |
renv_scope_verbose_if <- function(value, scope = parent.frame()) { | |
if (value) { | |
renv_scope_options( | |
renv.verbose = TRUE, | |
scope = scope | |
) | |
} | |
} |
value
-> TRUE
makes the logic a bit clearer IMO and I think it's good practice to always have a scope
argument.
Since the output we display might be controlled by
renv.verbose
.