-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom conversion function no longer works with reticulate >= 1.36.0 #1613
Comments
Thanks for reporting! This is fixed on main now. By the way, I noticed that numpy recarrays inherit from S3 class |
Thanks! Do know when it might reach CRAN?
Ok. I think that wasn't the case when I wrote this originally but I'll check again. Thanks for the tip. |
We just submitted a new release to CRAN last week (May 21). CRAN policy states that updates should be “no more than every 1–2 months”. Adhering to the CRAN policy, the soonest next update would be ~ June 21. However, occasionally, we do a rapid release in violation of the CRAN policy if circumstances warrant it. I think this regression has been live on CRAN for ~50 days already (since Reticulate 1.36). How impactful would another 20 days be? |
I think that should be fine in this case as there is a fairly easy workaround by getting people to install v |
Hi
In the {zellkonverter} Bioconductor package we have some custom Python to R conversion functions. One of these that is designed to handle numpy
recarray
's (array type 20) no longer works with {reticulate}>= 1.36.0
.Here is a small example (there is probably a nicer way to write this but this works):
As far as I can tell, the custom conversion function is not being called at all. It seems like there were some fairly major changes with v
1.36.0
so if you have any advice on what might be causing this change and how to address it that would be great. Or if there is an alternative/better way to handle converting these arrays that would also be helpful.Thanks!
The text was updated successfully, but these errors were encountered: