req()/isTruthy() can give suprising results for matrices (with NAs)

[cpsievert]

Some might consider this surprising behavior:

m <- matrix(c(NA, "b", "c", NA), 2, 2)
#>     [,1] [,2]
#> [1,] NA   "c" 
#> [2,] "b"  NA 
shiny::isTruthy(m)
#> FALSE

The reason m is falsy is that stats::na.omit() returns a 0 row matrix:

x <- stats::na.omit(m)
str(x)
#> chr[0 , 1:2] 
#> - attr(*, "na.action")= 'omit' num [1:2] 1 2
nzchar(x)
#> logical(0)

I suppose this might be expected if you truly want to discard all rows with any NA, but that may not always be the case. It would probably make sense for req()/isTruthy() to gain a na.action = na.omit argument to customize the handling of NAs