Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to vetiver_endpoint() #120

Closed
1 of 2 tasks
juliasilge opened this issue Jul 7, 2022 · 0 comments · Fixed by #134
Closed
1 of 2 tasks

Improvements to vetiver_endpoint() #120

juliasilge opened this issue Jul 7, 2022 · 0 comments · Fixed by #134
Labels
feature a feature request or enhancement

Comments

@juliasilge
Copy link
Member

juliasilge commented Jul 7, 2022 •
edited
Loading

Let's add some helpful checking to the currently very thin class for vetiver_endpoint(). Currently we know we would like to:

  • Check that the URL is actually a URL and possibly also is up?
  • Remove any trailing /
@juliasilge juliasilge added the feature a feature request or enhancement label Jul 7, 2022
@juliasilge juliasilge moved this from Todo to Backlog in MLOps with vetiver 🏺 Jul 7, 2022
@isabelizimm isabelizimm mentioned this issue Jul 7, 2022
Merged
@juliasilge juliasilge mentioned this issue Aug 12, 2022
Merged
Repository owner moved this from Backlog to Done in MLOps with vetiver 🏺 Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement
Projects
MLOps with vetiver 🏺
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove any trailing slash in vetiver_endpoint() rstudio/vetiver-r
1 participant
@juliasilge