Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor metadata, specifically move required_pkgs #168

Closed
juliasilge opened this issue Dec 8, 2022 · 1 comment · Fixed by #176
Closed

Refactor metadata, specifically move required_pkgs #168

juliasilge opened this issue Dec 8, 2022 · 1 comment · Fixed by #176
Labels
feature a feature request or enhancement

Comments

@juliasilge
Copy link
Member

We've decided to keep as much metadata as possible outside of the binary bundle, stored in plain text (YAML). As of today, here is what is wrapped up into the binary object:

x = list(model = vetiver_model$model,
ptype = vetiver_model$ptype,
required_pkgs = vetiver_model$metadata$required_pkgs),

In R, we don't have any tool like pydantic that can completely/accurately store that can store the signature/schema/ptype of a dataframe in plain text like JSON or YAML. This means that for now, we will keep the prototype / ptype in the list() that gets serialized to binary when storing.

It is possible/easier to move required_pkgs to the user metadata slot, since it's just plain text.

@juliasilge juliasilge added the feature a feature request or enhancement label Dec 8, 2022
@juliasilge
Copy link
Member Author

Related to #116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant