You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
my proposal is to introduce 3 optional parameters (that follows job.status):
SLACK_MESSAGE_ON_SUCCESS
SLACK_MESSAGE_ON_FAILURE
SLACK_MESSAGE_ON_CANCEL
and if they are specified, then use them. if any of them is missing, then use default from SLACK_MESSAGE (to keep backward compatibility).
In other words:
it would help us to reduce the amount of code needed to send notification that depends on status.
what do you think about it? or maybe there is already better way to achieve that? (right now i will give a try to elvis-operator workaround: actions/runner#409 (comment))
thanks for the action 🚀
BTW i see some PRs that i am interested in (GHES url), when can we expect new version with all the features? 😸
The text was updated successfully, but these errors were encountered:
Hi guys,
we are using this awesome action for notificaitons in our release process.
The only issue we are having is to configure it twice, like that:
my proposal is to introduce 3 optional parameters (that follows job.status):
SLACK_MESSAGE_ON_SUCCESS
SLACK_MESSAGE_ON_FAILURE
SLACK_MESSAGE_ON_CANCEL
and if they are specified, then use them. if any of them is missing, then use default from SLACK_MESSAGE (to keep backward compatibility).
In other words:
MESSAGE_TO_SEND_ON_SUCCESS= SLACK_MESSAGE_ON_SUCCESS not empty ? SLACK_MESSAGE_ON_SUCCESS : SLACK_MESSAGE
MESSAGE_TO_SEND_ON_FAILURE=...
MESSAGE_TO_SEND_ON_CANCEL
MESSAGE_TO_SEND= job.status == success ? MESSAGE_TO_SEND_ON_SUCCESS : (job.status == failure ? MESSAGE_TO_SEND_ON_FAILURE : MESSAGE_TO_SEND_ON_CANCEL)
it would help us to reduce the amount of code needed to send notification that depends on status.
what do you think about it? or maybe there is already better way to achieve that? (right now i will give a try to elvis-operator workaround: actions/runner#409 (comment))
thanks for the action 🚀
BTW i see some PRs that i am interested in (GHES url), when can we expect new version with all the features? 😸
The text was updated successfully, but these errors were encountered: