Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove copyright application #3199

Closed
agjohnson opened this issue Oct 27, 2017 · 5 comments · Fixed by #3400
Closed

Remove copyright application #3199

agjohnson opened this issue Oct 27, 2017 · 5 comments · Fixed by #3400
Labels
Good First Issue Good for new contributors

Comments

@agjohnson
Copy link
Contributor

This was brought up in review and not handled. Doesn't look like we need it any longer?
@agjohnson agjohnson added the Good First Issue Good for new contributors label Oct 27, 2017
@kikisdeliveryservice
Copy link

Hi! I'm new to rtd. Is this referring to removing from base.py?

@agjohnson
Copy link
Contributor Author

Greetings! 👋

It is, though the copyright application is likely called somewhere else in code as well. It shouldn't take much work at all, but I haven't looked into removing this yet.

If you want to try removing this, our development installation guide is here:
http://docs.readthedocs.io/en/latest/install.html#installing-read-the-docs

@agjohnson
Copy link
Contributor Author

Original PR here: #1300

@kikisdeliveryservice
Copy link

kikisdeliveryservice commented Nov 1, 2017 •
edited
Loading

Cool! I'll give it a try =) Thanks for replying so quickly!

@stsewd
Copy link
Member

stsewd commented Dec 10, 2017

I would like to do an PR, or are you working on this, @kikisdeliveryservice?

@stsewd stsewd mentioned this issue Dec 14, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Good for new contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove copyright application stsewd/readthedocs.org
3 participants
@agjohnson @stsewd @kikisdeliveryservice