Update changelog more consistently #3405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
agjohnson
commented
Dec 14, 2017
agjohnson
commented
- Get the last modified date from git, not local file as normally expected
- Make sure we're on master to run
- Don't do reset to master on release
* Get the last modified date from git, not local file as normally expected * Make sure we're on master to run * Don't do reset to master on release
|
More unrelated errors |
ericholscher
approved these changes
Dec 14, 2017
| # Get last modified date from Git instead of assuming the file metadata is | ||
| # correct. This can change depending on git reset, etc. | ||
| git_log = ctx.run('git log -1 --format="%ad" -- CHANGELOG.rst') | ||
| last_modified = parse(git_log.stdout.strip()).strftime('%Y-%m-%d') |
There was a problem hiding this comment.
We should put a note in the changelog that it's auto-generated, and not to touch it manually.
There was a problem hiding this comment.
Actually, one of the benefits of this tool is that it only updates the changelog for last release. It does allow for authoring in between generating and commiting, so we can add deployment and migration notes, or more general description of some of the changes
humitos
reviewed
Dec 15, 2017
| # Ensure we're on the master branch first | ||
| git_rev_parse = ctx.run('git rev-parse --abbrev-ref HEAD', hide=True) | ||
| current_branch = git_rev_parse.stdout.strip() | ||
| if current_branch != 'rel': |
There was a problem hiding this comment.
why rel here? shouldn't be master?
I mean, it checks if we are in rel and if not, it says "hey, you need to be on master"
Other, we want to ensure we are on rel not on master, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.