Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add celery theme to supported ad options #3425

Merged
merged 1 commit into from
Dec 21, 2017
Merged

Add celery theme to supported ad options #3425

merged 1 commit into from
Dec 21, 2017

Conversation

ericholscher
Copy link
Member

No description provided.

humitos
humitos reviewed Dec 20, 2017
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Question, why do we need those two new fonts?

and, readthedocs-doc-embed.js it's an autogenerated file that includes the new changes to the sponsorship.js? So, instead of dowloading a couple of files from one page, just download one, the -embed.js?

@ericholscher
Copy link
Member Author

The fonts were just autoincluded when I ran grunt. Yea we have one file thats run on doc pages.

@ericholscher ericholscher merged commit 7004cf0 into master Dec 21, 2017
@agjohnson agjohnson deleted the celery-sponsorship branch December 24, 2017 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos left review comments

@agjohnson agjohnson Awaiting requested review from agjohnson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericholscher @humitos @RichardLitt