Allow to import public repositories on corporate site

[humitos]

When the DEFAULT_PRIVACY_LEVEL is private we allow to import
public and private repositories from Bitbucket service.

This handles an issue under .com, https://github.com/readthedocs/readthedocs-corporate/issues/225

[agjohnson]

This is certainly something that we should have caught. Tests here would be a good addition.

[humitos]

I just pushed a test for this, but I will add a comment on the commit since we need to find out how to make it valid :)

[humitos]

This is the most important part of the test.

The problem we have here is how are the method defined and how they use this setting:

• the setting is accessed at https://github.com/rtfd/readthedocs.org/blob/415120759b9abbf67092a1e4781341b0d58f205a/readthedocs/oauth/services/bitbucket.py#L22
• so, when it's accessed the first time, it's public (the default) and the BitbucketService.create_repository is created with public as default for privacy at https://github.com/rtfd/readthedocs.org/blob/415120759b9abbf67092a1e4781341b0d58f205a/readthedocs/oauth/services/bitbucket.py#L90-L92
• finally, my @override_settings patch has no effect

The test passes because it's a public repo under a public default privacy level.

What it should be the best way to handle this? Should we make privacy as None by default and access the settings object inside the create_repository method?

cc @agjohnson

[agjohnson]

Yeah, this probably makes the most sense. 👍

[humitos]

@agjohnson after the changes, this is ready to be merged. Please, take another look if you can.

[agjohnson]

Looks great! 👍 on the tests for other providers as well. Make our tests more defensive is a smart idea.