Upgrade django-taggit to 0.22.2 #3667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade this package to be more prepared for Python3 and Django 2.0
|
Does this work in dev? |
davidfischer
approved these changes
Feb 26, 2018
There was a problem hiding this comment.
LGTM.
This is working for me in dev, @ericholscher.
It is unclear why we switched from a released taggit version to version directly from git, but it based on #843 it appears it was done before Django 1.6. Based on taggit's Changelog the changes appear minor and around compatibility. There are no new migrations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade this package to be more prepared for Python3 and Django 2.0
Related #3666