Define useful celery beat task for development #3762
Conversation
| orphan_domain_path = os.path.join(domain_path, cname) | ||
| log.info('Unlinking orphan CNAME: %s', orphan_domain_path) | ||
| os.unlink(orphan_domain_path) | ||
|
|
There was a problem hiding this comment.
I wonder if these should go in another file. projects/tasks is already huge, so it might make sense to move this into core/tasks.py or somewhere else specifically for scheduled tasks?
There was a problem hiding this comment.
Yes. I agree with this.
I created this issue (#3775) to refactor this and include some other tasks also --we can discuss in the issue.
There was a problem hiding this comment.
I actually dislike putting things in core. Why not split up into:
readthedocs.projects.tasks.buildreadthedocs.projects.tasks.sync- etc
Some of the tasks might make more sense in builds/ as well. I find core/ is not a helpful concept, save for only the most generalized of code.
| @@ -240,6 +243,19 @@ def USE_PROMOS(self): # noqa | |||
| CELERY_CREATE_MISSING_QUEUES = True | |||
|
|
|||
| CELERY_DEFAULT_QUEUE = 'celery' | |||
| CELERYBEAT_SCHEDULE = { | |||
There was a problem hiding this comment.
We need to make sure we aren't overridding this elsewhere. We need a good pattern here, but I'm guessing we aren't extending this everywhere else we use it, so this might get killed by a downstream config file overwriting it.
There was a problem hiding this comment.
I found we use this setting in 3 places:
- pydoc.io, but I think this project doesn't extend from RTD.org, so nothing to worry about
- org operations, which I've already made a PR to use the
@property - corporate site (https://github.com/readthedocs/readthedocs-corporate/blob/master/readthedocsinc/settings/base.py#L175) which I suppose that I need to do the same than I did for org.
@ericholscher please confirm this, and I will open a PR for corporate ops to modify this file https://github.com/readthedocs/readthedocs-corporate-ops/blob/master/salt/corporate/readthedocsinc/settings/base.py
There was a problem hiding this comment.
You need a property override there as well, correct.
|
Looks like just a linting error. We can address that separately. Merging! |
Define the task here and remove it from
readthedocs-ops.