oauth/services: don't abuse log.exception

[xrmx]

log.exception should not be used outside exception handlers

[humitos]

Thanks for your contribution.

I'm not sure I follow this change, though. When an unhandled exception happen, we want to log it with the whole traceback which is useful for debugging.

Those log.exceptions belongs to the clause try/except/else which are valid.

Why do you think it's better to log.error instead of log.exception here?

[xrmx]

Because else is not for unhandled exceptions but for code that does not raise any exception:

>>> try:
...   raise ValueError
... except KeyError:
...   pass
... else:
...   print('am not here')
... 
Traceback (most recent call last):
  File "<stdin>", line 2, in <module>
ValueError

[humitos]

Yeah, I got confused. Sorry about that.

So, we probably want to refactor that code since if the else is excecuted when any exception was risen, why we are logging an error? It doesn't make sense to me.

[xrmx]

Because of if resp.status_code == 201: and the likes in the try block.

[humitos]

I understand. I'd say that code needs to be rewritten with an easy to follow and clear flow, then :)

[xrmx]

If you have time I'd do some audit of try-else usage in RTD, the next PR is fixing another misusage :)

[ericholscher]

Thanks!