static: use modern getJSON callbacks

[xrmx]

Use done() and fail() instead of complete() and success() that got
removed in jquery 3.0.

[stsewd]

Thanks, you need to regenerate the minified js https://docs.readthedocs.io/en/latest/development/standards.html#getting-started

[xrmx]

@stsewd i've not regerated them on purpose to avoid issues with review / merge latency. If you are fine with the PR i can build the static files.

[stsewd]

Those are deprecated in version 2? We still use 2.0.3

https://github.com/rtfd/readthedocs.org/blob/110347355921fe82aee57ef04160a7a3477dedef/bower.json#L17-L17

[xrmx]

Are deprecated since 1.5 or 1.6 can't remember.

[xrmx]

Updated branch with rebuilt static files

[xrmx]

Updated PR to fix merge conflict

[xrmx]

New build conflicts, what about starting to open PR with only the source changed and have a commiter rebuild the static files?

[stsewd]

I was thinking about that too, I don't remember what the core team said about that

[ericholscher]

Tested this locally and it looks good. 👍

[codecov]

Codecov Report

Merging #4382 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4382   +/-   ##
=======================================
  Coverage   76.21%   76.21%           
=======================================
  Files         158      158           
  Lines       10019    10019           
  Branches     1265     1265           
=======================================
  Hits         7636     7636           
  Misses       2039     2039           
  Partials      344      344