Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect user language when caching homepage #4585

Merged
merged 2 commits into from
Aug 29, 2018
Merged

Respect user language when caching homepage #4585

merged 2 commits into from
Aug 29, 2018

Conversation

agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Aug 29, 2018 •
edited
Loading

Previously it was using the first language that hit the page to cache.

Fixes #4582

@agjohnson
Respect user language when caching homepage
686956b 
Previously it was using the first language that hit the page to cache.
@agjohnson agjohnson requested a review from a team August 29, 2018 21:29
@agjohnson agjohnson added Bug A bug Accepted Accepted issue on our roadmap labels Aug 29, 2018
@agjohnson agjohnson added this to the 2.7 milestone Aug 29, 2018
@agjohnson
Copy link
Contributor Author

Failure unrelated.

@agjohnson agjohnson added the PR: hotfix Pull request applied as hotfix to release label Aug 29, 2018
@agjohnson agjohnson added PR: hotfix Pull request applied as hotfix to release and removed PR: hotfix Pull request applied as hotfix to release labels Aug 29, 2018
@agjohnson
Copy link
Contributor Author

Just going to merge this. @rtfd/core be wary of this when caching new things.

@agjohnson agjohnson merged commit fd4cc67 into master Aug 29, 2018
@agjohnson agjohnson deleted the agj/cache-homepage-with-language branch August 29, 2018 22:38
humitos
humitos reviewed Aug 30, 2018
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@davidfischer davidfischer mentioned this pull request May 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos left review comments

Assignees
No one assigned
Labels
Accepted Accepted issue on our roadmap Bug A bug PR: hotfix Pull request applied as hotfix to release
Projects
None yet
Milestone
2.9
Development

Successfully merging this pull request may close these issues.
2 participants
@agjohnson @humitos