Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get_vcs_repo by moving it to the Mixin #4727

Merged
merged 2 commits into from
Oct 6, 2018
Merged

Fix get_vcs_repo by moving it to the Mixin #4727

merged 2 commits into from
Oct 6, 2018

Conversation

ericholscher
Copy link
Member

No description provided.

@ericholscher ericholscher requested a review from a team October 4, 2018 09:42
@ericholscher ericholscher added the PR: hotfix Pull request applied as hotfix to release label Oct 4, 2018
humitos
humitos approved these changes Oct 4, 2018
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix the problem that we just noted in latest deploy.

@humitos
Copy link
Member

humitos commented Oct 4, 2018

There was a timeout error on one of the search tests. I restarted the job but it should be fine.

@ericholscher
Copy link
Member Author

THis is deployed and fixed the error. 👍

stsewd
stsewd approved these changes Oct 4, 2018
View reviewed changes
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for breaking this :( I think I missed to test this after a rebase/merge

@ericholscher ericholscher merged commit d1c8c86 into master Oct 6, 2018
@stsewd stsewd deleted the fix-get_vcs_repo branch October 6, 2018 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

@stsewd stsewd stsewd approved these changes

Assignees
No one assigned
Labels
PR: hotfix Pull request applied as hotfix to release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericholscher @humitos @stsewd