Use $HOME as CWD for virtualenv creation #4852
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4852 +/- ##
=======================================
Coverage 76.41% 76.41%
=======================================
Files 158 158
Lines 9990 9990
Branches 1262 1262
=======================================
Hits 7634 7634
Misses 2016 2016
Partials 340 340
|
| # Don't use virtualenv bin that doesn't exist yet | ||
| bin_path=None, | ||
| # Don't use the project's root, some config files can interfere | ||
| cwd='$HOME', |
There was a problem hiding this comment.
I wonder if we should be running this from /tmp or something else that isn't in the checkout. I guess we aren't always sure any other path will exist (unless we make one w/ the tempfile module), so this seems fine. But I do wonder if we'll hit other issues at some point (eg. if we add our own pyproject.toml` file for RTD?
There was a problem hiding this comment.
Do the docker containers have access to the rtd code? I don't think so. But, yeah, using /tmp sounds better. People running this outside docker could have some problems I think, but I'm less worried about that. Should I go for plain /tmp or create one with the tempfile module?
There was a problem hiding this comment.
Ah good point, I forgot about Docker not having access. I think we can just go with $HOME for now, because it feels overkill (and could lead to errors) to create a temp directory.
Turns out we do support shell expansions in the CWD :)
Closes #4808