Remove repeated and dead code #4929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
commented
Nov 27, 2018
| if status > 0: | ||
| log.error('Could not symlink path: status=%d error=%s', | ||
| status, stderr) | ||
| result = self.environment.run('ln', '-nsf', docs_dir, symlink) |
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## master #4929 +/- ##
=========================================
+ Coverage 76.75% 76.86% +0.1%
=========================================
Files 158 158
Lines 10048 10005 -43
Branches 1265 1257 -8
=========================================
- Hits 7712 7690 -22
+ Misses 1995 1979 -16
+ Partials 341 336 -5
|
|
This is really annoying/hard to review because of the linting fixes along with code changes. |
stsewd
force-pushed
the
remove-repeated-code
branch
from
4290370
to
2b5b875
Compare
|
Sorry, I have divided the PR into two commits, 2b5b875 contains the real change |
ericholscher
approved these changes
Nov 27, 2018
humitos
approved these changes
Nov 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3540
I did a couple of builds and everything looks good.