Remove header nav (Login/Logout button) on 404 pages #5085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are using the same 404.html template for 404 errors when serving documentation (.io) and also on our platform (.org). The Login/Logout button only shows the proper word when the 404 page comes from .org, but it always says "Login" when we hit .io 404 pages. As this is only confusing and there is not value added here, I'm removing it completely.
|
Before,
After,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using the same 404.html template for 404 errors when serving documentation (.io) and also on our platform (.org).
The Login/Logout button only shows the proper word when the 404 page comes from .org, but it always says "Login" when we hit .io 404 pages.
As this is only confusing and there is not value added here, I'm removing it completely.