Remove approvals requirement from mergable #5200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think there is a setting inside github to force approvals before merge |
|
There it is
|
|
Set it to require one review 👍 |
stsewd
reviewed
Jan 30, 2019
.github/mergeable.yml
Outdated
| min: | ||
| count: 1 | ||
| message: 'The PR must have a minimum of 1 approvals.' | ||
| # Removed because it causes every PR to fail |
There was a problem hiding this comment.
I guess we can just remove this lines since we have set up this from github
stsewd
approved these changes
Jan 30, 2019
|
For labels, I think we should add in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just causes every PR to fail, which is terrible UX.